remove high cardinality labels server_route_id and server_gateway_id #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
caleblloyd
commented
Mar 7, 2024
| @@ -112,132 +111,6 @@ and no additional NATS metrics when there is no connectivity to the NATS system. | |||
| allows users to differentiate between a problem with the exporter itself connectivity with | |||
| the NATS system. | |||
|
|
|||
| ### Scrape Output | |||
There was a problem hiding this comment.
This section is wildly out of date, so just removing it
|
Since there can be multiple connections per route as of nats 2.10.x, removing the route ID is likely causing an issue |
|
Added a commit to remap Route/Gateway IDs to indexes, which will reduce cardinality coming from config reloads where routes/gateways always get new IDs |
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
caleblloyd
force-pushed
the
high-cardinality-fix
branch
from
ba62ef0
to
c32e1d6
Compare
caleblloyd
force-pushed
the
high-cardinality-fix
branch
from
54264ea
to
b9672ad
Compare
suckatrash
reviewed
Mar 8, 2024
suckatrash
approved these changes
Mar 8, 2024
Merged
caleblloyd
pushed a commit
that referenced
this pull request
May 31, 2024
caleblloyd
added a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #191