Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnats RPM packaging #483

Closed
sergey-safarov opened this issue Nov 6, 2021 · 8 comments
Closed

libnats RPM packaging #483

sergey-safarov opened this issue Nov 6, 2021 · 8 comments

Comments

@sergey-safarov
Copy link

I have prepared SPEC file for libnats packaging.
Could you make make libnats package

libnats.spec

@kozlovic
Copy link
Member

kozlovic commented Nov 8, 2021

I am sorry, I am not familiar at all with RPM packaging, so if you could let me know what needs to be done, I would appreciate it. Otherwise, I will have to research and I am quite busy at the moment, so that would not be a high priority.

@sergey-safarov
Copy link
Author

Could you show the folder where you plan to store packaging files?
I will create PR with instructions on how to manually build rpm packages.

If you use docker, I can create instructions or bash (Makefile) that will allow building rpm package using docker.

@kozlovic
Copy link
Member

kozlovic commented Nov 8, 2021

Could you show the folder where you plan to store packaging files?

Again, I know nothing about that, so not sure what you are asking here. I am cc'ing a colleague that knows more about that so he may be able to chime in and educate me ;-) @philpennock

If you use docker, I can create instructions or bash (Makefile) that will allow building rpm package using docker.

I release the library just with sources. Users build themselves. I actually provide CMakeLists.txt files (using CMake) so I don't have to learn or deal with platform specific build environments

@sergey-safarov
Copy link
Author

I release the library just with sources. Users build themselves. I actually provide CMakeLists.txt files (using CMake) so I don't have to learn or deal with platform specific build environments

So I will write only readme file.

@philpennock
Copy link
Member

I last touched a .spec file in 2012, so I can't give a meaningful review, but this looks sane. The bigger issue will be arranging for automated builds and packaging, so that we don't require macOS developers to have rpm installed locally. Normally, I use something like nfpm for cross-platform packaging.

At present, we just do source-code releases. I don't think we're willing to start binary library releases at this time?

@sergey-safarov
Copy link
Author

Thanks for the answer.
You can also place to repo spec file and do not build any RPM package binaries.
Users can build packages by themselves.
I can update the README file with two strings on how to build the package on RPM-based dist.

@kozlovic
Copy link
Member

kozlovic commented Jan 3, 2022

@sergey-safarov Yes, as we mentioned we release only the source. If you want to have the .spec file included and update the README, I would recommend that you submit a PR for that. Thanks!

@sergey-safarov
Copy link
Author

Closing this as relevant PR created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants