-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
microservices header missing #701
Comments
Noted by the header contents that it is incomplete maybe this is blocking based on completion so feel free to close. |
@geiseri Since v3.7.0, the service framework was released, so I think this header should have been included indeed, even if there are still TODOs. Will create a PR to address that. |
@kozlovic looking at the internals maybe it should be in the examples directory. The "args format" looks like is specific to the example as it wouldn't have enough of a schema for interop. |
micro-args was kind of a stop-gap TBH, for examples only. I will move it there. |
Moving Moving 0/5 we should just leave the files where they are, and perhaps replace the use of |
@levb Maybe the "mistake" was to make this example program a bit too configurable ;-). The parameters could have been hard coded, in that the value of the examples was to show how to use the service APIs, not really to be able to run actual fibonnaci or factorial computations :-) But I would not want to pull a JSON dependency just for that. As you said, we have tried hard to limit the dependencies, so it would be a shame to add one just for the examples. Note that most of the build issues reported by users are around the protobuf (to compile the NATS Streaming client). |
I agree. For now, I am proposing a PR that moves all this serialization business into a single .h file under examples. Will make |
@levb did you make that ticket? I have some ideas on that. |
Observed behavior
The header
micro_args.h
is missing from the install files.Expected behavior
It is added to the install section of src/CMakeLists.txt
Server and client version
release 3.7.0
Host environment
No response
Steps to reproduce
No response
The text was updated successfully, but these errors were encountered: