Moved micro_args to examples #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
LGTM. But while I was compiling on Windows (to make sure that there was no issue), I saw a warning caused by your previous PR (the pause consumer):
[ 97%] Building C object test/CMakeFiles/testsuite.dir/test.c.obj
test.c
E:\cnats\test\test.c(24331): warning C4307: '*': integral constant overflow
E:\cnats\test\test.c(24346): warning C4307: '*': integral constant overflow
E:\cnats\test\test.c(24350): warning C4307: '*': integral constant overflow
Would you mind making this change?
diff --git a/test/test.c b/test/test.c
index 2bad703d..ffd76631 100644
--- a/test/test.c
+++ b/test/test.c
@@ -24325,7 +24325,7 @@ test_JetStreamMgtConsumers(void)
cfg.Name = "my_name";
cfg.DeliverSubject = "mn.foo";
cfg.FilterSubject = "bar.>";
-#define TIME_20350101 (2051251200L * 1000000000L)
+#define TIME_20350101 ((int64_t)2051251200L * (int64_t)1000000000L)
if (serverVersionAtLeast(2, 11, 0))
{
cfg.PauseUntil = TIME_20350101;
levb
added a commit
that referenced
this pull request
Mar 15, 2024
…732) Co-authored-by: levb <1187448+levb@users.noreply.github.com>
levb
added a commit
that referenced
this pull request
Apr 12, 2024
* Moved micro_args to examples * PR feedback: Windows fix in test.c (unrelated)
|
Cherry-picked for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #701