Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] JetStream Ordered Consumers #468

Merged
merged 3 commits into from
Oct 5, 2021
Merged

[ADDED] JetStream Ordered Consumers #468

merged 3 commits into from
Oct 5, 2021

Conversation

kozlovic
Copy link
Member

The new Ordered option in jsSubOptions allows the jetstream subscription to be created as an ordered consumer.
It means that the subscription will be based on a fifo ephemeral consumer for in order delivery of messages.
There are no redeliveries and no acks. Flow control and heartbeats are required and set by default, but the heartbeats value can be overridden in the consumer configuration.

This will be used by tests for ordered consumers.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Check that the flowcontrol aspect has same "fix" as Go client to avoid stalls with first messages being large and processing being slow.

Also fixed some tabulations...

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 7281f61 into main Oct 5, 2021
@kozlovic kozlovic deleted the js_ordered_consumers branch October 5, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants