Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] JetStream: durable name cannot contain "." character #474

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Oct 7, 2021

The check was done only when calling js_AddConsumer(), but needs
to be done on subscribe also, and also check that the queue
name does not contain "." character when it is used as the
durable name.

Resolves #473

Signed-off-by: Ivan Kozlovic ivan@synadia.com

The check was done only when calling js_AddConsumer(), but needs
to be done on subscribe also, and also check that the queue
name does not contain "." character when it is used as the
durable name.

Resolves #473

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 6073b5f into main Oct 7, 2021
@kozlovic kozlovic deleted the js_fix_dur_name branch October 7, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetStream: subscribe calls should fail if durable name contains "."
2 participants