[IMPROVED] crypto: effectively zeroize mem. content #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When libsodim is not used, memory content is zeroized using a simple memset() and de-allocated using free(), so compiler may decide to remove memset(). This patch add secure_memzero(), similar to sodium_zero(), to be sure to zeroize memory content also when libsodium is not used.
kozlovic
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
libsodimis not used, memory content is zeroized using a simplememset()and de-allocated usingfree(), so compiler may decide to removememset().This patch add
secure_memzero(), similar tosodium_zero(), to be sure to zeroize memory content also whenlibsodiumis not used.