[FIXED] nuid: fix wrong sizeof in memset #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
requested changes
Jan 16, 2022
src/nuid.c
Outdated
| @@ -208,7 +208,7 @@ natsNUID_init(void) | |||
| natsStatus s; | |||
| unsigned int seed = (unsigned int) nats_NowInNanoSeconds(); | |||
|
|
|||
| memset(&globalNUID, 0, sizeof(natsNUID)); | |||
| memset(&(globalNUID.nuid), 0, sizeof(globalNUID.nuid)); | |||
There was a problem hiding this comment.
Good catch in that the memset was wrong, but it was the sizeof() that was wrong, not the address of the object. Here, I wanted to initialize globalNUID, which is a natsLockedNUID object, which itself, is a pointer to a mutex and the natsNUID structure. So the proper initialization is:
memset(&globalNUID, 0, sizeof(natsLockedNUID));
There was a problem hiding this comment.
I’ll update, but mutex is initialized one line after, so I used memset() in this way.
There was a problem hiding this comment.
But that was the point of the memset: if the initialization of the mutex fails, calling natsNUID_free() in case of error would then be dangerous because globalNUID.mu pointer may not have been initialized to NULL.
Fixes following Coverity issue: Passing argument &globalNUID of type natsLockedNUID * and argument 32UL (sizeof (natsNUID)) to function memset is suspicious because sizeof (natsLockedNUID) /*40*/ is expected. Signed-off-by: Paolo Teti <paolo.teti@gmail.com>
kozlovic
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes following Coverity issue:
Passing argument &globalNUID of type natsLockedNUID * and
argument 32UL (sizeof (natsNUID)) to function memset is suspicious
because sizeof (natsLockedNUID) /40/ is expected.
Signed-off-by: Paolo Teti paolo.teti@gmail.com