Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] JetStream: Nak delay and BackOff list #516

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Feb 2, 2022

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 8514634 into main Feb 2, 2022
@kozlovic kozlovic deleted the nak_delay_and_backoff branch February 2, 2022 17:43
kozlovic added a commit that referenced this pull request Mar 1, 2022
This is due to a change in PR #516 that is making any Ack call
that passes an option to transform the call to sync calls if
option has a Wait value set.
The auto-ack callback was calling ack with the jetstream's context
options, which has always a Wait by default of 5sec.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants