Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed InactiveThreshold consumer configuration handling #518

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

kozlovic
Copy link
Member

The field was not (un)marshal'ed and the test that was supposed
to check the feature was actually checking the opposite, that is,
that the consumer was found instead of not found !!!

Related to #515

Signed-off-by: Ivan Kozlovic ivan@synadia.com

The field was not (un)marshal'ed and the test that was supposed
to check the feature was actually checking the opposite, that is,
that the consumer was found instead of not found !!!

Related to #515

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit b8e60a2 into main Feb 10, 2022
@kozlovic kozlovic deleted the fix_inactive_threshold branch February 10, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants