[CHANGED] PurgeDeletes() will now keep markers that are less than 30min old #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in old There is a breaking change where kvStore_PurgeDeletes() accepts now kvPurgeOptions instead of kvWatchOptions. We needed from kvWatchOptions only the timeout, and as it standed, it was bad since user could have passed watcher options that would have affected the internal watcher that we make to collect delete markers. Also, when invoking kvStore_PurgeDeletes(), the delete markers that are older than a default of 30 minutes will be deleted, however more recent ones will be kept. The data is always removed, even if a marker is not. The user can change the 30 minutes threshold using a new purge option called kvPurgeOptions.DeleteMarkersOlderThan. If set to -1, it restores the old behavior of deleting delete/purge markers, regardless of their age. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a breaking change where kvStore_PurgeDeletes() accepts now
kvPurgeOptions instead of kvWatchOptions.
We needed from kvWatchOptions only the timeout, and as it standed, it was
bad since user could have passed watcher options that would have
affected the internal watcher that we make to collect delete markers.
Also, when invoking kvStore_PurgeDeletes(), the delete markers that
are older than a default of 30 minutes will be deleted, however more
recent ones will be kept. The data is always removed, even if a marker
is not.
The user can change the 30 minutes threshold using a new purge
option called kvPurgeOptions.DeleteMarkersOlderThan. If set to -1,
it restores the old behavior of deleting delete/purge markers,
regardless of their age.
Signed-off-by: Ivan Kozlovic ivan@synadia.com