[ADDED] Stream RePublish and some ConsumerConfig new fields #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely for pull consumers: ability to override the replica count or storage type:
```
// Generally inherited by parent stream and other markers, now can be configured directly.
Replicas int `json:"num_replicas"`
// Force memory storage.
MemoryStorage bool `json:"mem_storage,omitempty"`
```
For the stream, this new StreamConfig option:
```
// Allow republish of the message after being sequenced and stored.
RePublish *SubjectMapping `json:"republish,omitempty"`
```
Where SubjectMapping is:
```
// SubjectMapping allows a source subject to be mapped to a destination subject for republishing.
type SubjectMapping struct {
Source string `json:"src,omitempty"`
Destination string `json:"dest"`
}
```
Note: Removed consumer config's MaxRequestMaxBytes that was added
in PR #543 until we settle how max_bytes in pull requests should behave
(both in client and server)
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
added a commit
that referenced
this pull request
Jul 22, 2022
Since this feature was not released, made the change to the name of the structure and added the HeadersOnly boolean to be on-par with the server. Related to #546 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely for pull consumers: ability to override the replica count or storage type:
For the stream, this new StreamConfig option:
Where SubjectMapping is:
Note: Removed consumer config's MaxRequestMaxBytes that was added
in PR #543 until we settle how max_bytes in pull requests should behave
(both in client and server)
Signed-off-by: Ivan Kozlovic ivan@synadia.com