Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix armel build #556

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix armel build #556

merged 1 commit into from
Jul 12, 2022

Conversation

linuxmaniac
Copy link
Contributor

Error: selected processor does not support `yield' in ARM mode

fixes nats-io#555

> Error: selected processor does not support `yield' in ARM mode
@linuxmaniac linuxmaniac changed the title fix armel build #555 fix armel build Jul 12, 2022
@kozlovic
Copy link
Member

@linuxmaniac Thank you for the contribution. I noticed from the build logs that there was a warning for a snprintf that I just fixed (#557). Also, notice from your log that you are using OpenSSL 1.1+ and so should add -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON in your cmake config (at one point, I should make this the default since OpenSSL 1.1 is now very common).

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please also check my comment about OpenSSL and the fix for the snprintf warning.

@kozlovic kozlovic merged commit 10ff89d into nats-io:main Jul 12, 2022
@linuxmaniac linuxmaniac deleted the vseva/armel branch July 18, 2022 08:40
@linuxmaniac
Copy link
Contributor Author

@kozlovic JFYI applied your patch for #557 and added -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON at the last version
https://buildd.debian.org/status/fetch.php?pkg=nats.c&arch=amd64&ver=3.3.0-4&stamp=1657760618&raw=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants