[CHANGED] Count message headers toward subscription limits #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When headers were introduced, the whole buffer (so data + hdr) was added as pending limits, but when messages were removed from the subscription, only the data part was removed, which caused an issue that was address in PR #420 by just accounting for the data size (not header). Headers becoming more and more prevalent, it could be that a big part of message content is the headers, so we should probably count the headers size along with the data toward the subscription's bytes limit. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When headers were introduced, the whole buffer (so data + hdr) was added as pending limits, but when messages were removed from the subscription, only the data part was removed, which caused an issue that was address in PR #420 by just accounting for the data size (not header).
Headers becoming more and more prevalent, it could be that a big part of message content is the headers, so we should probably count the headers size along with the data toward the subscription's bytes limit.
Signed-off-by: Ivan Kozlovic ivan@synadia.com