Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGED] JetStream: js_GetStreamInfo() now returns all subjects #588

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

kozlovic
Copy link
Member

When the option jsOptions.Stream.Info.SubjectsFilter is specified, the js_GetStreamInfo() would collect the subjects for the stream and return them in si->State.Subjects. However, the server had a 100,000 limit. Since server v2.9.0, pagination is supported therefore this call is going to under the cover get the info until all pages have been collected.

Related to nats-io/nats-architecture-and-design#153

Signed-off-by: Ivan Kozlovic ivan@synadia.com

When the option jsOptions.Stream.Info.SubjectsFilter is specified,
the js_GetStreamInfo() would collect the subjects for the stream
and return them in si->State.Subjects. However, the server had
a 100,000 limit. Since server v2.9.0, pagination is supported
therefore this call is going to under the cover get the info
until all pages have been collected.

Related to nats-io/nats-architecture-and-design#153

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit eeafb9f into main Sep 20, 2022
@kozlovic kozlovic deleted the js_stream_info_subjects branch September 20, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants