Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered Consumr reset changes #598

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Ordered Consumr reset changes #598

merged 1 commit into from
Oct 4, 2022

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Oct 4, 2022

  • Was not setting to MemoryStorage and Replicas of 1 on recreate
  • Added test that checks for MemoryStorage after a reset
  • Improved error reporting when failing to recreate the consumer

Related to #596

Signed-off-by: Ivan Kozlovic ivan@synadia.com

- Was not setting to MemoryStorage and Replicas of 1 on recreate
- Added test that checks for MemoryStorage after a reset
- Improved error reporting when failing to recreate the consumer

Related to #596

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from aricart October 4, 2022 21:06
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit d6d0244 into main Oct 4, 2022
@kozlovic kozlovic deleted the js_oc_reset branch October 4, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants