[FIXED] Reconnecting to implicit URL would not use known user info #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user provides an URL with a username and password but the library discovers new servers and a disconnect occurs, the library would reconnect without the username and password. The option `natsOptions_SetUserInfo()` is normally recommended to solve this issue. However, to be closer to other client libraries, this library will now save the username/password of an explicit URL and use those for implicit URLs (unless the aforementioned option is used). Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user provides an URL with a username and password but the library discovers new servers and a disconnect occurs, the library would reconnect without the username and password. The option
natsOptions_SetUserInfo()is normally recommended to solve this issue.However, to be closer to other client libraries, this library will now save the username/password of an explicit URL and use those for implicit URLs (unless the aforementioned option is used).
Signed-off-by: Ivan Kozlovic ivan@synadia.com