[ADDED] KeyValue: Support for Mirror and Sources #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated state for proper Put() and Get() semantics with mirrors and across domains, e.g. leafnodes. In practice when a mirror is across a domain, should be named the same as origin. That allows an app to run anywhere without anything special in terms of domains when binding to the KV itself. (Removed dead-code following previous PR #607) Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Needed to have delete use the put prefix and bind to the stream when creating the watcher's subscription because in case of mirror the subject would not allow to find the stream. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
kv_mirror_source_cross_domains
branch
from
c736d16
to
4613e1f
Compare
|
@aricart If you could have a look at the 2nd commit. It fixes the issue with delete/purge_deletes/watch. (correction, purge_deletes was working as-is, just added a test to verify that it works) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated state for proper Put() and Get() semantics with mirrors and across domains, e.g. leafnodes.
In practice when a mirror is across a domain, should be named the same as origin. That allows an app to run anywhere without anything special in terms of domains when binding to the KV itself.
(Removed dead-code following previous PR #607)
Signed-off-by: Ivan Kozlovic ivan@synadia.com