[FIXED] Bytes accounting while reading the INFO protocol #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrmax
changed the title
kozlovic
changed the title
kozlovic
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is potential buffer overflow vulnerability that can be exploited if server is controlled by an intruder.
If we detect that the buffer contains data then we have to reduce available space for the subsequent read operation. Otherwise read can overwrite memory past the buffer.
P.S.: Just discovered that this function is called only from one place and supplied buffer is always empty there. So actualy not a vulnerabilty but as it is written should be fixed in case anyone in future will use this function with non-empty buffer.