Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] natsConnection_GetConnectedUrl() not working during reconnect #636

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Feb 8, 2023

This function, and natsConnection_GetConnectedServerId() would work only when the connection was fully connected. There is no reason to not make it work while the connection is reconnecting.

Resolves #635

Signed-off-by: Ivan Kozlovic ivan@synadia.com

This function, and natsConnection_GetConnectedServerId() would work
only when the connection was fully connected. There is no reason
to not make it work while the connection is reconnecting.

Resolves #635

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from aricart February 8, 2023 00:17
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@kozlovic kozlovic merged commit 835de29 into main Feb 10, 2023
@kozlovic kozlovic deleted the fix_635 branch February 10, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature callback does not know the server URL
2 participants