[FIXED] natsConnection_RequestMsg() incorrectly returns NATS_NO_SERVER_SUPPORT #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levb
approved these changes
Mar 9, 2023
| @@ -104,7 +104,7 @@ natsConn_publish(natsConnection *nc, natsMsg *msg, const char *reply, bool direc | |||
| // accessing the headers. It should still be considered having headers. | |||
| if ((msg->headers != NULL) || natsMsg_needsLift(msg)) | |||
| { | |||
| if (!nc->info.headers) | |||
There was a problem hiding this comment.
nit: 0/5 update the comment with the comment from this PR to explain why initc is excluded?
…R_SUPPORT When using `natsOptions_SetRetryOnFailedConnect` option to connect and the library is not yet connected, calling `natsConnection_RequestMsg` with a message with headers would incorrectly return `NATS_NO_SERVER_SUPPORT` instead of `NATS_TIMEOUT`. Resolves #644 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
natsOptions_SetRetryOnFailedConnectoption to connect and the library is not yet connected, callingnatsConnection_RequestMsgwith a message with headers would incorrectly returnNATS_NO_SERVER_SUPPORTinstead ofNATS_TIMEOUT.Resolves #644
Signed-off-by: Ivan Kozlovic ivan@synadia.com