Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Missing connection status check causing unexpected delay during connection close #654

Merged
merged 1 commit into from
May 15, 2023

fix race condition causing unexpected delay during connection close

5bc5156
Select commit
Loading
Failed to load commit list.
Merged

[FIXED] Missing connection status check causing unexpected delay during connection close #654

fix race condition causing unexpected delay during connection close
5bc5156
Select commit
Loading
Failed to load commit list.
Travis CI / Travis CI - Pull Request succeeded May 15, 2023 in 9m 41s

Build Passed

The build passed, just like the previous build.

Details

This is a pull request build.

It is running a build against the merge commit, after merging #654 fix race condition causing unexpected delay during connection close.
Any changes that have been made to the main branch before the build ran are also included.

Jobs and Stages

This build has 11 jobs, running in parallel.

Job Compiler ENV OS State
1819.1 gcc DO_COVERAGE="coverage" BUILD_OPT="-DNATS_COVERAGE=ON -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON" Linux passed
1819.2 clang DO_COVERAGE="coverage" BUILD_OPT="-DNATS_COVERAGE=ON -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON" Linux passed
1819.3 gcc-9 - TLS OFF gcc MATRIX_EVAL="CC=gcc-9" Linux passed
1819.4 gcc-9 - Streaming OFF gcc MATRIX_EVAL="CC=gcc-9" Linux passed
1819.5 gcc-9 - Default - sanitize address gcc MATRIX_EVAL="CC=gcc-9" Linux passed
1819.6 gcc-9 - Lib msg delivery - sanitize address gcc MATRIX_EVAL="CC=gcc-9" Linux passed
1819.7 gcc-9 - Write deadline - sanitize address gcc MATRIX_EVAL="CC=gcc-9" Linux passed
1819.8 gcc-9 - Default - sanitize thread gcc MATRIX_EVAL="CC=gcc-9" Linux passed
1819.9 clang-8 - TLS OFF clang MATRIX_EVAL="CC=clang-8" Linux passed
1819.10 clang-8 - Default - sanitize address clang MATRIX_EVAL="CC=clang-8" Linux passed
1819.11 clang-8 - Default - sanitize thread clang MATRIX_EVAL="CC=clang-8" Linux passed

Build Configuration

Build Option Setting
Language C++
Operating System Linux (Bionic)
Compiler Versions gcc, clang
Build Configuration
{
  "language": "cpp",
  "os": [
    "linux"
  ],
  "dist": "bionic",
  "cache": {
    "directories": [
      "$HOME/deps"
    ]
  },
  "compiler": [
    "gcc",
    "clang"
  ],
  "before_install": [
    "bash install_deps.sh",
    "if [ \"$DO_COVERAGE\" = \"coverage\" ]; then pip install --user cpp-coveralls; fi",
    "eval \"${MATRIX_EVAL}\""
  ],
  "before_script": [
    "export PATH=$HOME/deps/cmake-install:$HOME/deps/cmake-install/bin:$HOME/deps/nats-server:$HOME/deps/nats-streaming-server:$PATH",
    "mkdir build && cd build"
  ],
  "env": [
    "jobs={:DO_COVERAGE=>\"\\\"coverage\\\"\", :BUILD_OPT=>\"\\\"-DNATS_COVERAGE=ON -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON\\\"\"}"
  ],
  "jobs": {
    "include": [
      {
        "name": "gcc-9 - TLS OFF",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_WITH_TLS=OFF -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - Streaming OFF",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_STREAMING=OFF -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\"",
            "CTEST_OPT": "\"-I 1,1\""
          }
        ]
      },
      {
        "name": "gcc-9 - Default - sanitize address",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - Lib msg delivery - sanitize address",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "NATS_DEFAULT_TO_LIB_MSG_DELIVERY": "yes",
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - Write deadline - sanitize address",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "NATS_DEFAULT_LIB_WRITE_DEADLINE": "2000",
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - Default - sanitize thread",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=thread\"",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "clang-8 - TLS OFF",
        "compiler": "clang",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "llvm-toolchain-xenial-8"
              }
            ],
            "packages": [
              "clang-8"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=clang-8\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_WITH_TLS=OFF -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\"",
            "CTEST_OPT": "\"-I 1,1\""
          }
        ]
      },
      {
        "name": "clang-8 - Default - sanitize address",
        "compiler": "clang",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "llvm-toolchain-xenial-8"
              }
            ],
            "packages": [
              "clang-8"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=clang-8\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "clang-8 - Default - sanitize thread",
        "compiler": "clang",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "llvm-toolchain-xenial-8"
              }
            ],
            "packages": [
              "clang-8"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=clang-8\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=thread\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      }
    ]
  },
  "script": [
    "$TRAVIS_BUILD_DIR/buildOnTravis.sh \"$CC\" \"$DO_COVERAGE\" \"$BUILD_OPT -DNATS_SANITIZE=ON -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON -DNATS_PROTOBUF_DIR=$HOME/deps/pbuf -DNATS_BUILD_USE_SODIUM=ON -DNATS_SODIUM_DIR=$HOME/deps/sodium\" \"$CTEST_OPT\""
  ],
  "after_success": [
    "cd ..",
    "if [[ \"$DO_COVERAGE\" == \"coverage\" && \"$TRAVIS_COMPILER\" == \"gcc\" ]]; then coveralls --gcov-options '\\-lp' -r . -i \"src/\" -e \"src/win/\" -e \"src/unix/\" -e \"src/stan/protocol.pb-c.c\" -E \".*\\.h$\"; fi"
  ],
  "notifications": {
    "email": [
      {
        "enabled": false
      }
    ]
  }
}