Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] natsConnection_Connect can get stuck and consume all memory #707

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Jan 11, 2024

If an error occurs when reading a protocol message during the connect phase, the library could spin appending a character into a buffer until the process would run out of memory.

Resolves #706

Signed-off-by: Ivan Kozlovic ivan@synadia.com

If an error occurs when reading a protocol message during the connect
phase, the library could spin appending a character into a buffer
until the process would run out of memory.

Resolves #706

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from levb January 11, 2024 02:43
@kozlovic
Copy link
Member Author

@levb One of travis' failure is due to an Ubuntu bug. See PR: #708

@levb levb merged commit da84f3c into main Jan 16, 2024
2 checks passed
@levb levb deleted the fix_706 branch January 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

natsConnection_Connect can get stuck in a very long, unproductive loop
2 participants