Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Missing NATS_EXTERN in nats.h for some functions. #715

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

kozlovic
Copy link
Member

This is important for Windows platform.

I also fixed a cast issue in util.c (that was reported on Windows build). Some changes are also related to spaces at end of lines that were removed by my editor.

Resolves #714

Signed-off-by: Ivan Kozlovic ivan@synadia.com

This is important for Windows platform.

I also fixed a cast issue in util.c (that was reported on Windows build).
Some changes are also related to spaces at end of lines that were removed
by my editor.

Resolves #714

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from levb January 27, 2024 19:58
Copy link
Collaborator

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OT: @kozlovic what (auto-)formatter do you use? So I can sync up my settings?

@levb levb merged commit 047bf52 into main Jan 29, 2024
2 checks passed
@levb levb deleted the fix_714 branch January 29, 2024 14:53
@kozlovic
Copy link
Member Author

what (auto-)formatter do you use? So I can sync up my settings?

@levb I am using VS Code, and in the Settings/Text Editor/Files, I have "Trim Trailing Whitespace" checkbox checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all functions exported in the Windows DLL
2 participants