Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] GH-738, do not prefix endpoint name with the group prefix #741

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[FIXED] GH-738, do not prefix endpoint name with the group prefix #741

merged 1 commit into from
Apr 5, 2024

Conversation

levb
Copy link
Collaborator

@levb levb commented Apr 4, 2024

Fixes #738

The Go client does not prefix the name, it was a mistake. Now identify the EPs by subject, like the Go client

@levb levb added this to the v3.8.1 milestone Apr 4, 2024
@levb levb assigned mtmk and Jarema Apr 4, 2024
@mtmk
Copy link
Contributor

mtmk commented Apr 5, 2024

fix looks good.

> nats micro list
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                             All Micro Services                                            │
├───────────────┬─────────┬────────────────────────┬────────────────────────────────────────────────────────┤
│ Name          │ Version │ ID                     │ Description                                            │
├───────────────┼─────────┼────────────────────────┼────────────────────────────────────────────────────────┤
│ c-arithmetics │ 1.0.0   │ Z77LYVHMUBP5HUIT6UNYQU │ Arithmetic operations - NATS microservice example in C │
╰───────────────┴─────────┴────────────────────────┴────────────────────────────────────────────────────────╯

did you want a review? you assigned to me but not a reviewer.

@levb levb requested review from mtmk and Jarema April 5, 2024 15:37
@levb levb unassigned mtmk and Jarema Apr 5, 2024
@levb
Copy link
Collaborator Author

levb commented Apr 5, 2024

@mtmk @Jarema Sry for misassignment, yes review please. This is a minor fix, about microservices.

mtmk
mtmk approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit a03aed8 into main Apr 5, 2024
2 checks passed
@levb levb deleted the lev-GH-738-micro-no-prefix-ep-name branch April 5, 2024 20:38
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@levb @github-actions
[skip ci] Update docs: a03aed8: [FIXED] GH-786, do not prefix endpoin…
640a03f 
…t name with the group prefix (#741)
levb added a commit that referenced this pull request Apr 5, 2024
@github-actions @levb
[skip ci] Update docs: a03aed8: [FIXED] GH-786, do not prefix endpoin…
792871b 
…t name with the group prefix (#741) (#742)

Co-authored-by: levb <1187448+levb@users.noreply.github.com>
levb added a commit that referenced this pull request Apr 5, 2024
@levb
[FIXED] GH-786, do not prefix endpoint name with the group prefix (#741)
6e8ecd5
@levb levb removed the cherry-pick label Apr 5, 2024
@levb
Copy link
Collaborator Author

levb commented Apr 5, 2024

cherry-picked into release-v3.8

levb added a commit that referenced this pull request Apr 12, 2024
@levb
[FIXED] GH-786, do not prefix endpoint name with the group prefix (#741)
eb7b3ec
@levb levb removed the cherry-pick label Apr 12, 2024
@levb
Copy link
Collaborator Author

levb commented Apr 12, 2024

Cherry-picked for v3.8.1, used the wrong branch before (removed it now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.

micro commands give parser errors on names
3 participants
@levb @mtmk @Jarema