[CHANGE] [SRV] [BREAKING] removed NamedEndpointStats#metadata refer…

…ence, reference `EndpointInfo#metadata` instead
nats-io · May 31, 2023 · 05eb6cd · 05eb6cd
1 parent 53843ce
commit 05eb6cd
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 13 deletions.
diff --git a/nats-base-client/core.ts b/nats-base-client/core.ts
@@ -926,10 +926,6 @@ export type NamedEndpointStats = {
    * Average processing_time is the total processing_time divided by the num_requests
    */
   average_processing_time: Nanos;
-  /**
-   * Endpoint Metadata
-   */
-  metadata?: Record<string, string>;
 };
 /**
  * Statistics for an endpoint

diff --git a/nats-base-client/service.ts b/nats-base-client/service.ts
@@ -322,7 +322,6 @@ export class ServiceImpl implements Service {
       this.internal.push(sv);
     }
     sv.stats = new NamedEndpointStatsImpl(name, subject);
-    sv.stats.metadata = h.metadata;
 
     const callback = handler
       ? (err: NatsError | null, msg: Msg) => {
@@ -630,7 +629,6 @@ class NamedEndpointStatsImpl implements NamedEndpointStats {
       processing_time,
       last_error,
       data,
-      metadata,
     } = this;
     return {
       name,
@@ -641,7 +639,6 @@ class NamedEndpointStatsImpl implements NamedEndpointStats {
       processing_time,
       last_error,
       data,
-      metadata,
     };
   }
 

diff --git a/tests/helpers/service-check.ts b/tests/helpers/service-check.ts
@@ -272,10 +272,6 @@ const statsSchema: JSONSchemaType<ServiceStats> = {
           processing_time: { type: "number" },
           average_processing_time: { type: "number" },
           data: { type: "string" },
-          metadata: {
-            type: "object",
-            minProperties: 1,
-          },
         },
         required: [
           "num_requests",
@@ -284,7 +280,6 @@ const statsSchema: JSONSchemaType<ServiceStats> = {
           "processing_time",
           "average_processing_time",
           "data",
-          "metadata",
         ],
       },
     },

diff --git a/tests/service_test.ts b/tests/service_test.ts
@@ -852,7 +852,6 @@ Deno.test("service - metadata", async () => {
   assertEquals(info.metadata, { service: "1" });
   const stats = await srv.stats();
   assertEquals(stats.endpoints?.length, 1);
-  assertEquals(stats.endpoints?.[0].metadata, { endpoint: "endpoint" });
 
   await cleanup(ns, nc);
 });