[FIX] added a check on createInbox() to reject prefixes that contain …

…wildcards
nats-io · Feb 6, 2023 · 15ee7d5 · 15ee7d5
1 parent 839642f
commit 15ee7d5
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/nats-base-client/protocol.ts b/nats-base-client/protocol.ts
@@ -65,6 +65,12 @@ export function createInbox(prefix = ""): string {
   if (typeof prefix !== "string") {
     throw (new Error("prefix must be a string"));
   }
+  prefix.split(".")
+    .forEach((v) => {
+      if (v === "*" || v === ">") {
+        throw new Error(`inbox prefixes cannot have wildcards '${prefix}'`);
+      }
+    });
   return `${prefix}.${nuid.next()}`;
 }
 

diff --git a/tests/basics_test.ts b/tests/basics_test.ts
@@ -1177,3 +1177,21 @@ Deno.test("basics - close promise resolves", async () => {
     fail(err);
   });
 });
+
+Deno.test("basics - inbox prefixes cannot have wildcards", async () => {
+  await assertRejects(
+    async () => {
+      await connect({ inboxPrefix: "_inbox.foo.>" });
+    },
+    Error,
+    "inbox prefixes cannot have wildcards",
+  );
+
+  assertThrows(
+    () => {
+      createInbox("_inbox.foo.*");
+    },
+    Error,
+    "inbox prefixes cannot have wildcards",
+  );
+});