[FIX] added check on fetch for use of max_bytes

nats-io · Jun 6, 2022 · 88ae3b1 · 88ae3b1
1 parent 13c518a
commit 88ae3b1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/nats-base-client/jsclient.ts b/nats-base-client/jsclient.ts
@@ -211,6 +211,12 @@ export class JetStreamClientImpl extends BaseApiClient
     const args: Partial<PullOptions> = {};
     args.batch = opts.batch || 1;
     if (max_bytes) {
+      const fv = this.nc.protocol.features.get(Feature.JS_PULL_MAX_BYTES);
+      if (!fv.ok) {
+        throw new Error(
+          `max_bytes is only supported on servers ${fv.min} or better`,
+        );
+      }
       args.max_bytes = max_bytes;
     }
     args.no_wait = opts.no_wait || false;

diff --git a/nats-base-client/semver.ts b/nats-base-client/semver.ts
@@ -38,7 +38,7 @@ export class Features {
     this.features = new Map<Feature, FeatureVersion>();
     this.server = v;
 
-    this.set(Feature.JS_PULL_MAX_BYTES, "2.8.5");
+    this.set(Feature.JS_PULL_MAX_BYTES, "2.8.3");
   }
 
   set(f: Feature, requires: string) {

diff --git a/tests/basics_test.ts b/tests/basics_test.ts
@@ -1168,12 +1168,12 @@ Deno.test("basics - server version", async () => {
   const { ns, nc } = await setup({});
   const nci = nc as NatsConnectionImpl;
   assertEquals(nci.protocol.features.require("3.0.0"), false);
-  assertEquals(nci.protocol.features.require("2.8.3"), true);
+  assertEquals(nci.protocol.features.require("2.8.2"), true);
 
-  const ok = nci.protocol.features.require("2.8.5");
+  const ok = nci.protocol.features.require("2.8.3");
   const bytes = nci.protocol.features.get(Feature.JS_PULL_MAX_BYTES);
   assertEquals(ok, bytes.ok);
-  assertEquals(bytes.min, "2.8.5");
+  assertEquals(bytes.min, "2.8.3");
   assertEquals(ok, nci.protocol.features.supports(Feature.JS_PULL_MAX_BYTES));
 
   await cleanup(ns, nc);

diff --git a/tests/jetstream_test.ts b/tests/jetstream_test.ts
@@ -3463,7 +3463,7 @@ Deno.test("jetstream - pull consumer max_bytes rejected on old servers", async (
       sub.pull({ expires: 2000, max_bytes: 2 });
     },
     Error,
-    "max_bytes is only supported on servers 2.8.5 or better",
+    "max_bytes is only supported on servers 2.8.3 or better",
   );
 
   await cleanup(ns, nc);