[FIX] expose stop error argument, as client handler will want this

nats-base-client/service.ts

@@ -78,10 +78,11 @@ export type Service = {
    */
   reset(): void;
   /**
-   * Stop the service returning a promise that resolves to null or an error
-   * depending on whether stopping resulted in an error.
+   * Stop the service returning a promise once the service completes.
+   * If the service was stopped due to an error, that promise resolves to
+   * the specified error
    */
-  stop(): Promise<null | Error>;
+  stop(err?: Error): Promise<null | Error>;
 };
 
 /**
@@ -578,8 +579,8 @@ export class ServiceImpl implements Service {
     return this._done;
   }
 
-  stop(): Promise<null | Error> {
-    return this.close();
+  stop(err?: Error): Promise<null | Error> {
+    return this.close(err);
   }
 
   reset(): void {

tests/service_test.ts

@@ -12,11 +12,14 @@ import {
   assertEquals,
   assertExists,
   assertRejects,
+  fail,
 } from "https://deno.land/std@0.125.0/testing/asserts.ts";
 import {
   Empty,
+  ErrorCode,
   JSONCodec,
   Msg,
+  NatsError,
   QueuedIterator,
 } from "../nats-base-client/mod.ts";
 import { NatsConnectionImpl } from "../nats-base-client/nats.ts";
@@ -199,3 +202,42 @@ Deno.test("service - handler error", async () => {
 
   await cleanup(ns, nc);
 });
+
+Deno.test("service - stop error", async () => {
+  const { ns, nc } = await setup({
+    authorization: {
+      users: [{
+        user: "a",
+        password: "a",
+        permissions: {
+          subscribe: {
+            deny: "fail",
+          },
+        },
+      }],
+    },
+  }, { user: "a", pass: "a" });
+
+  const service = await addService(nc, {
+    name: "test",
+    endpoint: {
+      subject: "fail",
+      handler: (err): Promise<void> => {
+        if (err) {
+          service.stop(err);
+          return Promise.reject(err);
+        }
+        fail("shouldn't have subscribed");
+        return Promise.resolve();
+      },
+    },
+  });
+
+  const err = await service.done as NatsError;
+  assertEquals(
+    err.code,
+    ErrorCode.PermissionsViolation,
+  );
+
+  await cleanup(ns, nc);
+});