isolated the 408 into its own error which is ignored

nats-io · Jan 25, 2022 · ca830f8 · ca830f8
1 parent 2a083ec
commit ca830f8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -30,7 +30,7 @@ jobs:
           deno-version: ${{ matrix.deno-version }}
 
       - name: Set NATS Server Version
-        run: echo "NATS_VERSION=v2.6.5" >> $GITHUB_ENV
+        run: echo "NATS_VERSION=v2.7.0" >> $GITHUB_ENV
 
       # this here because dns seems to be wedged on gha
       - name: Add hosts to /etc/hosts

diff --git a/nats-base-client/jsclient.ts b/nats-base-client/jsclient.ts
@@ -238,7 +238,9 @@ export class JetStreamClientImpl extends BaseApiClient
             timer = null;
           }
           if (
-            isNatsError(err) && err.code === ErrorCode.JetStream404NoMessages
+            isNatsError(err) &&
+            (err.code === ErrorCode.JetStream404NoMessages ||
+              err.code === ErrorCode.JetStream408RequestTimeout)
           ) {
             qi.stop();
           } else {

diff --git a/nats-base-client/jsutil.ts b/nats-base-client/jsutil.ts
@@ -96,7 +96,7 @@ export function checkJsErrorCode(
   switch (code) {
     case 408:
       return NatsError.errorForCode(
-        ErrorCode.JetStream404NoMessages,
+        ErrorCode.JetStream408RequestTimeout,
         new Error(description),
       );
     case 503: