[TEST] fix some flappers

nats-io · May 12, 2023 · e7a3a5e · e7a3a5e
1 parent c398886
commit e7a3a5e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/tests/helpers/asserts.ts b/tests/helpers/asserts.ts
@@ -59,6 +59,7 @@ export async function assertThrowsAsyncErrorCode<T = void>(
 }
 
 export function assertBetween(n: number, low: number, high: number) {
-  console.assert(n >= low, `${n} >= ${low}`);
-  console.assert(n <= high, `${n} <= ${low}`);
+  if(!(n >= low && high >= n)) {
+    fail(`${n} >= ${low} && ${high} >= ${n}`)
+  }
 }
diff --git a/tests/jetstream_test.ts b/tests/jetstream_test.ts
@@ -556,7 +556,7 @@ Deno.test("jetstream - fetch expires waits", async () => {
     }
   })();
   const elapsed = Date.now() - start;
-  assertBetween(elapsed, 950, 1050);
+  assertBetween(elapsed, 950, 1250);
   assertEquals(iter.getReceived(), 0);
   await cleanup(ns, nc);
 });
@@ -579,7 +579,7 @@ Deno.test("jetstream - fetch expires waits after initial", async () => {
     }
   })();
   const elapsed = Date.now() - start;
-  assertBetween(elapsed, 950, 1050);
+  assertBetween(elapsed, 950, 1250);
   assertEquals(iter.getReceived(), 1);
   await cleanup(ns, nc);
 });
@@ -1095,7 +1095,7 @@ Deno.test("jetstream - fetch none - no wait breaks fast", async () => {
 
   await done;
   sw.mark();
-  assert(25 > sw.duration());
+  assertBetween(sw.duration(), 0, 125)
   assertEquals(batch.getReceived(), 0);
   await cleanup(ns, nc);
 });
@@ -1125,7 +1125,7 @@ Deno.test("jetstream - fetch one - no wait breaks fast", async () => {
 
   await done;
   sw.mark();
-  assert(25 > sw.duration());
+  assertBetween(sw.duration(), 0, 125)
   assertEquals(batch.getReceived(), 1);
   await cleanup(ns, nc);
 });
@@ -1159,7 +1159,7 @@ Deno.test("jetstream - fetch none - cancel timers", async () => {
 
   await done;
   sw.mark();
-  assert(25 > sw.duration());
+  assertBetween(sw.duration(), 0, 125);
   assertEquals(batch.getReceived(), 0);
   await cleanup(ns, nc);
 });

diff --git a/tests/streams_test.ts b/tests/streams_test.ts
@@ -107,7 +107,8 @@ Deno.test("streams - mirrors", async () => {
   );
 
   const s2 = await s.best();
-  assertEquals(s2.name, alternates[0].name);
+  assertExists(s2);
+  assertEquals(s2.name, (await s.info(true)).alternates?.[0].name);
 
   await nc.close();
   await NatsServer.stopAll(cluster);