Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: WPI (jsmsg.working()) is not resending as first ack, will prevent others. #154

Closed
aricart opened this issue May 13, 2021 · 0 comments · Fixed by #155
Closed

JS: WPI (jsmsg.working()) is not resending as first ack, will prevent others. #154

aricart opened this issue May 13, 2021 · 0 comments · Fixed by #155

Comments

@aricart
Copy link
Member

aricart commented May 13, 2021 •
edited

the jsmsg ack added a regression to prevent double acks (ie, user handler nack, but then an auto-ack was set). This restriction is only necessary if a non-terminal ack is sent (ack, nak, term).
aricart added a commit that referenced this issue May 13, 2021
@aricart
[fix] fixed an issue where preventing double-acks prevented repeat in…
1edfdc6 
…vocations of +WPI, which should be allowed an unbounded number of times.

FIX #154
@aricart aricart mentioned this issue May 13, 2021
Merged
aricart added a commit that referenced this issue May 14, 2021
@aricart
[fix] fixed an issue where preventing double-acks prevented repeat in…
e134b7b 
…vocations of +WPI, which should be allowed an unbounded number of times. (#155)

FIX #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@aricart