Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial js support #117

Merged
merged 21 commits into from
Mar 12, 2021
Merged

initial js support #117

merged 21 commits into from
Mar 12, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Mar 12, 2021

No description provided.

- export basic jetstream types
- fix tests
…g for an empty value, when server is sending nil.

- changed stored message type to always have header
- added tests
changed to make errors only codes ≥ 300
removed functionality that destroys the consumer on unsubscribe, instead provided a `destroy` option to the jetstream subscription where the consumer can be explicitly destroyed.
added tests for consumer options
@aricart aricart requested a review from kozlovic March 12, 2021 23:27
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants