Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request validation doesn't reject properly in downstream #216

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 2, 2021

[FIX] in some downstream environments the assertion for the subject doesn't seem to auto-reject properly even if there's a handler associated with the promise.

…oesn't seem to auto-reject properly even if there's a handler associated with the promise.
@aricart aricart requested a review from kozlovic November 2, 2021 17:22
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit ce4f4aa into main Nov 2, 2021
@aricart aricart deleted the request-assert branch November 2, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants