Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [SRV] response types #449

Merged
merged 2 commits into from
Dec 30, 2022
Merged

[FEAT] [SRV] response types #449

merged 2 commits into from
Dec 30, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Dec 29, 2022

No description provided.

@aricart aricart changed the base branch from main to dev December 29, 2022 16:33
@@ -50,7 +50,21 @@ export enum ServiceVerb {
SCHEMA = "SCHEMA",
}

export interface ServiceIdentity {
export enum ServiceResponseType {
STATS = "io.nats.micro.v1.stats",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 03accc4 into dev Dec 30, 2022
@aricart aricart deleted the srv-response-types branch December 30, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants