timestamp types were incorrectly tagged as Nanos rather than strings #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovided by the server (time() returns a Date object which will have lower precision) [FIX] fixed StreamInfo.created to be a `string` (was marked as Nanos), StreamState@first_ts to be a string. Fixes nats-io/nats.js#556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] Added StoredMessage#timestamp returns the ISO message timestamp as provided by the server (
#time()returns aDateobject which will have lower precision)[FIX]
StreamInfo.createdto be astring(was marked asNanos),StreamState#first_tsto be a string.Fixes nats-io/nats.js#556