Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ObjectStore meta subject entries name encoding #490

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Mar 8, 2023

[FIX] [BREAKING] [OS] previous versions of object store incorrectly base64 encoded without padding - this made javascript created entries be incompatible with other clients. The tool bin/fix-os.ts can be used to fix existing object stores - however it is important for a backup of the stream to be made prior to using it.

FIX #489

@aricart aricart requested a review from Jarema March 8, 2023 00:26
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@delaneyj delaneyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎆

…ase64 encoded without padding - this made javascript created entries be incompatible with other clients. The tool bin/fix-os.ts can be used to fix existing object stores - however it is important for a backup of the stream to be made prior to using it.
@aricart aricart temporarily deployed to CI March 8, 2023 16:51 — with GitHub Actions Inactive
@aricart aricart merged commit ab40594 into main Mar 8, 2023
@aricart aricart deleted the fix-meta-encoding branch March 8, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base64 padding mismatch
3 participants