Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] subject transforms #494

Merged
merged 1 commit into from
Mar 15, 2023
Merged

[FEAT] subject transforms #494

merged 1 commit into from
Mar 15, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Mar 15, 2023

[FEAT] [JS] StreamConfig can specify a subject_transform to apply a transform to incoming messages before anything else.

[FEAT] [JS] StreamSource configurations can specify a SubjectTransformConfig to map a source and destination pattern.

… a transform to incoming messages before anything else.

[FEAT] [JS] `StreamSource` configurations can specify a `SubjectTransformConfig` to map a source and destination pattern.
@jnmoyne
Copy link

jnmoyne commented Mar 15, 2023

FWIW subject transform for republish is already there in 2.9
It's missing the subject transform in SourceConfig

@jnmoyne
Copy link

jnmoyne commented Mar 15, 2023

Also another thing missing (though maybe you want to do another PR for it) is the support for sourcing in KV (which automatically sets the subject transform destination in the stream source) see https://github.com/nats-io/nats.go/blob/5931be06a7a54d34ff5d68772f6d73412eb24ed7/kv.go#L416

@aricart
Copy link
Member Author

aricart commented Mar 15, 2023

I'll do a separate PR to keep them in line.

Copy link

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 338ce74 into dev Mar 15, 2023
@aricart aricart deleted the subj-transforms branch March 15, 2023 23:04
@aricart
Copy link
Member Author

aricart commented Mar 15, 2023

FWIW subject transform for republish is already there in 2.9 It's missing the subject transform in SourceConfig

The republish was completed long ago:
nats-io/nats-architecture-and-design#139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants