Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumer sub leaks #515

Merged
merged 1 commit into from
May 18, 2023
Merged

consumer sub leaks #515

merged 1 commit into from
May 18, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented May 18, 2023

simplified consumer was leaking subscriptions

@aricart aricart requested a review from piotrpio May 18, 2023 17:24
@aricart aricart temporarily deployed to CI May 18, 2023 19:32 — with GitHub Actions Inactive
@aricart aricart requested a review from scottf May 18, 2023 19:33
scottf
scottf approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit be8e2c3 into dev May 18, 2023
1 check passed
@aricart aricart deleted the srv-sub-leaks branch May 18, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottf scottf scottf approved these changes

@piotrpio piotrpio Awaiting requested review from piotrpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aricart @scottf