Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status iterator doesn't cleanup if the iterator is stopped #547

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

aricart
Copy link
Member

@aricart aricart commented Jun 22, 2023

[FIX] pull adds a status listener on every call, and has no mechanism for removing it - this modifies it so that if the status iterator closes it is removed from the list

Fixes #546

… for removing it - this modifies it so that if the status iterator closes it is removed from the list
@aricart aricart temporarily deployed to CI June 22, 2023 20:00 — with GitHub Actions Inactive
@aricart aricart requested a review from scottf June 22, 2023 20:00
Copy link

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 747dd38 into dev Jun 22, 2023
2 checks passed
@aricart aricart deleted the fix-546 branch June 22, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants