Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os changes to update and links #596

Merged
merged 1 commit into from Sep 20, 2023
Merged

os changes to update and links #596

merged 1 commit into from Sep 20, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 20, 2023

[JETSTREAM] [OS] [CHANGE] The update() method will now delete the previous meta for an object - previously, it reused the storage of the entry - this matched the original go client implementation.

[JETSTREAM] [OS] [CHANGE] links now always store link metadata - previously, if, on the same object store, it would duplicate the source metadata entry.

[JETSTREAM] [OS] [FIX] links of links are now rejected

[DOC] added documentation on the object store API

…revious meta for an object - previously it reused the storage of the entry - this matched the original go client implementation.

[JETSTREAM] [OS] [CHANGE] links now always store a link metadata - previously, if on the same object store, it would duplicate the source metadata entry.

[JETSTREAM] [OS] [FIX] links of links are now rejected

[DOC] added documentation on the objectstore API
@aricart aricart requested a review from Jarema September 20, 2023 16:06
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 7707f9c into main Sep 20, 2023
3 checks passed
@aricart aricart deleted the os-link-updates branch September 20, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants