[TEST] Cluster tool fixes #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path and tmp folder fixes fpr Windows. Also signal handling fixes for Windows and Linux.
aricart
requested changes
Nov 15, 2023
| @@ -140,28 +146,36 @@ function restart(cluster: NatsServer[]) { | |||
| } | |||
|
|
|||
| function waitForStop(): void { | |||
| const isWindows = Deno.build.os === "windows"; | |||
| const isLinux = Deno.build.os === "linux"; | |||
There was a problem hiding this comment.
lets just test for windows, the rest is assumed to be some sort of unix, otherwise we'll fail and add more complexity for other things that will run
There was a problem hiding this comment.
This is only for signal handling on Linux swapping ctrl-T with ctrl-Z since SIGINFO doesn't work on Linux. It'd be nice to have the option to run on Linux as well. BTW macOS should not be affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path and tmp folder fixes fpr Windows.
Also signal handling fixes for Windows and Linux.