[CHANGE] [JS] [CONSUMERS] fetch()/next() can fail on consumer/stream errors #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to react to consumer deleted / not found server responses. Since these operations have a termination condition, such events are appropriate. Consume however will keep reporting if there's an error related to the stream or consumer. Clients that want to stop processing during a consume on consumer deleted/stream not found type errors should setup a listener and then call stop on the consumer if those conditions are reported. Order consumers work similarly in next() and fetch() as described above with the exception that consumer not found, really will attempt to recover (as ordered consumers recreate the consumer when there's an error). Applications that use next()/fetch() should trap errors, and re-attempt as desired.
…rce` to consume which will bail a consume if a resource such as a stream/consumer is not found or deleted. By default, `consume()` will attempt to recover.
…ordered consumer can overcome.
|
For the ordered consumer, when |
No, because consumer not found on ordered consumer will recreate.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the behavior of
fetch()andnext()to react toconsumer deleted/consumer not found/stream not foundserver responses. Since these operations have a termination condition (the end of thenext()orfetch()), such events are appropriate.Ordered consumers work similarly with
next()andfetch()as described above. Applications that use next()/fetch() should trap errors, and re-attempt as desired.consume()API however will keep reporting via itsstatus()if there's an error related to the stream or consumer. Clients that want to stop processing during a consume on consumer deleted/stream not found type errors should setup a listener and then callstop()on the consumer if those conditions are reported and the desired behavior is to stop processing. If the problem resource becomes available,consume()will resume. This is the existing behavior.This PR also adds the
abort_on_missing_resourcetoconsume()options. If a resource such as a stream is not found or consumer is deleted or not foundconsume()will abort. Note that for ordered consumers will not honor the option if a consumer is not found, as order consumer recreates a consumer on the fly. However deleting an active ordered consumer or its stream will stop it if the option is provided.