Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Kv Watcher reliability during server restarts #689

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

aricart
Copy link
Member

@aricart aricart commented Apr 22, 2024

[FIX] [JS] [KV] watcher reset due to a server restart could fail because the server would report the consumer as existing

[FIX] [JS] [KV] watcher reset if successful, could still get heartbeat missing reports which would cause the ordered consumer to reset when it didn't need to.

Fix #688

…use the server would report the consumer as existing

[FIX] [JS] [KV] watcher reset if successful, could still get heartbeat missing reports which would cause the ordered consumer to reset when it didn't need to.

Fix #688
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 66a47b9 into main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KV watch functionality fails when NATS server restarts
2 participants