Merge pull request #717 from wallyqs/jsm-stream-name

jsm: Check that stream name is valid on AddStream // StreamInfo

jsm.go

@@ -532,6 +532,10 @@ func (js *js) AddStream(cfg *StreamConfig, opts ...JSOpt) (*StreamInfo, error) {
 		return nil, ErrStreamNameRequired
 	}
 
+	if strings.Contains(cfg.Name, ".") {
+		return nil, ErrInvalidStreamName
+	}
+
 	req, err := json.Marshal(cfg)
 	if err != nil {
 		return nil, err
@@ -555,6 +559,10 @@ func (js *js) AddStream(cfg *StreamConfig, opts ...JSOpt) (*StreamInfo, error) {
 type streamInfoResponse = streamCreateResponse
 
 func (js *js) StreamInfo(stream string, opts ...JSOpt) (*StreamInfo, error) {
+	if strings.Contains(stream, ".") {
+		return nil, ErrInvalidStreamName
+	}
+
 	o, cancel, err := getJSContextOpts(js.opts, opts...)
 	if err != nil {
 		return nil, err

test/js_test.go

@@ -1584,6 +1584,20 @@ func TestJetStreamManagement(t *testing.T) {
 		}
 	})
 
+	t.Run("create bad stream", func(t *testing.T) {
+		_, err := js.AddStream(&nats.StreamConfig{Name: "foo.invalid"})
+		if err != nats.ErrInvalidStreamName {
+			t.Fatalf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("bad stream info", func(t *testing.T) {
+		_, err := js.StreamInfo("foo.invalid")
+		if err != nats.ErrInvalidStreamName {
+			t.Fatalf("Unexpected error: %v", err)
+		}
+	})
+
 	t.Run("stream update", func(t *testing.T) {
 		if _, err := js.UpdateStream(nil); err == nil {
 			t.Fatal("Unexpected success")