[FIXED] KV_ prefix when listing key value stores (#1487)

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
nats-io · Dec 12, 2023 · f8caaf9 · f8caaf9
1 parent 55224f3
commit f8caaf9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/jetstream/kv.go b/jetstream/kv.go
@@ -423,7 +423,7 @@ func (js *jetStream) KeyValueStoreNames(ctx context.Context) KeyValueNamesLister
 				if !strings.HasPrefix(name, kvBucketNamePre) {
 					continue
 				}
-				res.kvNames <- name
+				res.kvNames <- strings.TrimPrefix(name, kvBucketNamePre)
 			}
 			if errors.Is(err, ErrEndOfData) {
 				return

diff --git a/jetstream/test/kv_test.go b/jetstream/test/kv_test.go
@@ -995,6 +995,9 @@ func TestListKeyValueStores(t *testing.T) {
 			names := make([]string, 0)
 			kvNames := js.KeyValueStoreNames(ctx)
 			for name := range kvNames.Name() {
+				if strings.HasPrefix(name, "KV_") {
+					t.Fatalf("Expected name without KV_ prefix, got %q", name)
+				}
 				names = append(names, name)
 			}
 			if kvNames.Error() != nil {

diff --git a/kv.go b/kv.go
@@ -1077,7 +1077,7 @@ func (js *js) KeyValueStoreNames() <-chan string {
 				if !strings.HasPrefix(name, kvBucketNamePre) {
 					continue
 				}
-				ch <- name
+				ch <- strings.TrimPrefix(name, kvBucketNamePre)
 			}
 		}
 	}()

diff --git a/test/kv_test.go b/test/kv_test.go
@@ -979,6 +979,9 @@ func TestListKeyValueStores(t *testing.T) {
 			}
 			names := make([]string, 0)
 			for name := range js.KeyValueStoreNames() {
+				if strings.HasPrefix(name, "KV_") {
+					t.Fatalf("Expected name without KV_ prefix, got %q", name)
+				}
 				names = append(names, name)
 			}
 			if len(names) != test.bucketsNum {