Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHANGED] Service schemas #1188

Merged
merged 1 commit into from Jan 13, 2023
Merged

[CHANGED] Service schemas #1188

merged 1 commit into from Jan 13, 2023

Conversation

piotrpio
Copy link
Collaborator

  • updated service schemas configuration according to ADR
  • fixed empty fields in STATS response

aricart
aricart approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a minor nit

@coveralls
Copy link

Coverage Status

Coverage: 85.493% (+0.03%) from 85.46% when pulling a70a75f on service-api-schema-update into 44509e6 on main.

ripienaar
ripienaar approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will defer to yous on the URL thing, I think a URL needs to be a URL so like the current approach

@piotrpio piotrpio merged commit dfc537e into main Jan 13, 2023
@piotrpio piotrpio deleted the service-api-schema-update branch January 13, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

@aricart aricart aricart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@piotrpio @coveralls @ripienaar @aricart