Move tests from nats package under test/* directory #1254
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVERVIEW
WHAT:
WHY:
nats.go
from bringing nats-server dependencies togo.mod
.DETAILS OF REQUEST
Reference
nats
package undertest/*
directory kubecon-contribfest#6Not Implemented
nc.mu.Lock()
and 'nc.mu.Unlock()' in tests.// Need access to the internals for testing.
for those tests.TestNoRaceObjectContextOpt
sometimes fails, but it's unrelated to this change.