Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGED] Move NakWithDelay to separate method #1337

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Jun 27, 2023

This cleans up the API a bit, avoiding having a method with a single option to modify the behavior.

Resolves #1299

@piotrpio piotrpio requested a review from Jarema June 27, 2023 13:29
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio merged commit 97ccbd8 into main Jun 28, 2023
1 of 2 checks passed
@piotrpio piotrpio deleted the nak-with-delay branch June 28, 2023 10:12
@piotrpio piotrpio mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Design nak with delay non testable with mocks
2 participants