Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] CreateConsumer and UpdateConsumer methods to work with server 2.10 capabilities #1379

Merged
merged 2 commits into from Aug 29, 2023

Conversation

piotrpio
Copy link
Collaborator

No description provided.

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Copy link
Contributor

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nit about the readme still having an example using CreateOrUpdate, otherwise LGTM!

@@ -253,16 +253,25 @@ CRUD operations on consumers can be achieved on 2 levels:
js, _ := jetstream.New(nc)

// create a consumer (this is an idempotent operation)
cons, _ := js.CreateOrUpdateConsumer(ctx, "ORDERS", jetstream.ConsumerConfig{
// an error will be returned if consumer already exists and has different configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still have an example using CreateOrUpdateConsumer() (since it is still there)

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio merged commit 2d59abc into 2.10.0 Aug 29, 2023
2 checks passed
@piotrpio piotrpio deleted the create-update-consumers branch August 29, 2023 10:09
piotrpio added a commit that referenced this pull request Sep 1, 2023
… 2.10 capabilities (#1379)

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio added a commit that referenced this pull request Sep 1, 2023
… 2.10 capabilities (#1379)

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio added a commit that referenced this pull request Sep 19, 2023
… 2.10 capabilities (#1379)

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio added a commit that referenced this pull request Sep 19, 2023
… 2.10 capabilities (#1379)

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio added a commit that referenced this pull request Sep 20, 2023
… 2.10 capabilities (#1379)

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants